Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for encrypted UserDefinedAttributeView #156

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

Support for encrypted UserDefinedAttributeView #156

wants to merge 6 commits into from

Conversation

overheadhunter
Copy link
Member

Fixes #47

  • Attribute names are c9r. + base64url-encoded siv-encrypted attribute names
  • Attribute values are encrypted in the same way as file contents

There is no shortening. TBD: How to deal with too long attribute names?

This PR replaces the stale branch feature/47-user-attr.

@overheadhunter overheadhunter requested a review from infeo January 5, 2023 12:41
infeo
infeo reviewed Jan 9, 2023
View reviewed changes
Copy link
Member

@infeo infeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Regarding handling of too long attributes: I'm totally fine by defining a limit and throw an IOException if the limit is exceeded. But I honstely don't know, what an appropiate limit would be.

@CLAassistant
Copy link

CLAassistant commented Nov 13, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infeo infeo infeo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for UserDefinedFileAttributeView
3 participants
@overheadhunter @CLAassistant @infeo